Issue1713

Title explorer of Windows Vista removes spaces from file names
Priority feature Status resolved
Superseder Nosy List abuehl, hgbot, mg, mpm, tonfa
Assigned To Topics windows

Created on 2009-06-26.15:16:00 by abuehl, last changed 2010-10-10.18:06:45 by abuehl.

Files
File name Uploaded Type Edit Remove
copy-error.png abuehl, 2009-06-26.15:15:59 image/png
Messages
msg13947 (view) Author: hgbot Date: 2010-10-10.18:00:05
Fixed by http://hg.intevation.org/mercurial/crew/rev/34d8247a4595
Adrian Buehlmann <adrian@cadifra.com>
store: encode first period or space in filenames (issue1713)
msg13448 (view) Author: abuehl Date: 2010-08-21.17:50:56
I've sent a patch to -devel that jumps on the 'parentdelta'
repo format bandwagon to fix this issue:

http://selenic.com/pipermail/mercurial-devel/2010-August/023899.html
msg12111 (view) Author: tonfa Date: 2010-03-20.21:35:19
Maybe we should revisit it since we have the other OSX bug?
msg9980 (view) Author: mpm Date: 2009-07-10.17:59:53
Marking this deferred - we're not going to try to deal with this until we have
some other major reason to change the store layout.
msg9782 (view) Author: abuehl Date: 2009-06-26.15:15:59
Explorer of Windows Vista and Windows 7 has the following bug:

When copying trees, it *removes* all spaces from the beginning
of file and directory names.

Tested on Vista 32bit, Vista 64bit and Windows 7 64bit.

This bug is *not* present in explorer.exe of Windows XP.

Note that on Windows Vista and Windows 7 (and of course Windows XP)
it is possible to create file and directory names beginning with
spaces using for example the rename command of cmd.exe:

rename a.txt " a.txt"

File- and directory names beginning with spaces are valid names
both for the OS and the file systems NTFS and FAT32.


Affected well known repository:

The python trunk repo for example contains the two files (names
given in double quotes):

"  separator ---.i"
"separator ---.i"

in ".hg/store/data/_mac/_i_d_e scripts".

If you try to copy that repo using explorer of Vista (or
Windows 7) you will get a warning box telling you that
it cannot copy the file "separator ---.i" to the destination
folder because that folder already contains a file with
that name (see attached copy-error.png).
No matter what the user chooses: the copied repo is broken
(fails on hg verify).
History
Date User Action Args
2010-10-10 18:06:45abuehlsetstatus: testing -> resolved
nosy: mpm, tonfa, mg, abuehl, hgbot
2010-10-10 18:00:05hgbotsetstatus: deferred -> testing
nosy: + hgbot
messages: + msg13947
2010-08-21 17:50:56abuehlsetnosy: mpm, tonfa, mg, abuehl
messages: + msg13448
2010-03-20 21:35:19tonfasetnosy: + tonfa
messages: + msg12111
2009-07-10 17:59:53mpmsetstatus: unread -> deferred
nosy: + mpm
messages: + msg9980
2009-06-26 22:43:43mgsetnosy: + mg
2009-06-26 15:16:00abuehlcreate