changeset:   10484:cadd7e076b69
branch:      stable
tag:         tip
user:        Benoit Boissinot <benoit.boissinot@ens-lyon.org>
date:        Mon Feb 15 22:39:36 2010 +0100
summary:     url: correctly quote '/' in user and password embedded in urls

diff --git a/mercurial/url.py b/mercurial/url.py
--- a/mercurial/url.py
+++ b/mercurial/url.py
@@ -180,6 +180,7 @@
             if not proxyuser:
                 proxyuser = ui.config("http_proxy", "user")
                 proxypasswd = ui.config("http_proxy", "passwd")
+            proxypasswd = urllib.quote(proxypasswd or '', safe='')
 
             # see if we should use a proxy for this url
             no_list = ["localhost", "127.0.0.1"]
@@ -196,7 +197,7 @@
 
             proxyurl = urlparse.urlunsplit((
                 proxyscheme, netlocunsplit(proxyhost, proxyport,
-                                                proxyuser, proxypasswd or 
''),
+                                                proxyuser, proxypasswd),
                 proxypath, proxyquery, proxyfrag))
             proxies = {'http': proxyurl, 'https': proxyurl}
             ui.debug('proxying through http://%s:%s\n' %

If one has this config file

[http_proxy]
host=proxy.here.com
user=john
passwd=pass/word

the '/' is not correctly handled since the password string is retrieved as
is from the config file and put in a 'url' describing the proxy settings,
then given to urllib.
In order to have a working config file we must write

[http_proxy]
host=proxy.here.com
user=john
passwd=pass%2Fword

which is far from instinctive (and not documented).

A solution is to replace every '/' by '%2F' in the password string before
giving it to the urllib.