Issue2997

Title Pulling from paths with fragments (#tag) broken between 1.7 and 1.9?
Priority bug Status resolved
Superseder Nosy List DanTup, danny, hgbot, kiilerix, mpm
Assigned To Topics

Created on 2011-09-10.09:35:24 by DanTup, last changed 2011-10-04.22:05:23 by mpm.

Files
File name Uploaded Type Edit Remove
unnamed danny, 2011-09-12.07:35:22 text/html
Messages
msg17376 (view) Author: DanTup Date: 2011-09-12.18:39:01
Maybe I did something wrong...

It looked like both "default" and "stable" branches had the fix, so I built 
default. I don't usually build this way, and had to run via Python (didn't 
know how to build hg.exe).

I'll try again tomorrow and have a colleague check what I'm doing.

Is there any way I can build hg.exe so I can test it the same way I found the 
issue (or if it's not easy for me, is it easy enough for you to build and send 
to me?).
msg17375 (view) Author: mpm Date: 2011-09-12.17:59:28
I don't have Windows, so I can only test the pieces here, but I've added a
debug statement to hg.py:parseurl and I now see:

$ hg clone '\\foo\bar#baz'
getting \\foo\bar branch baz  <- properly parsed
abort: repository \\foo\bar not found!  <- used only the path

And this works:

$ hg clone hg#stable hgs
getting hg branch stable  <- properly parsed
adding changesets
adding manifests
adding file changes                                                             
added 14883 changesets with 29147 changes to 2054 files                         
updating to branch stable  <- used the branch
930 files updated, 0 files merged, 0 files removed, 0 files unresolved

So everything here points to all the codepaths working.
msg17361 (view) Author: danny Date: 2011-09-12.07:35:22
This doesn't seem to have worked - although the checkout succeeds, I appear
to be on the tip tag rather than the tag I picked.

(Note: I'm running this through Python manually, as I wasn't sure how to
build an hg.exe, which is the way I originally found this problem - I
usually use the Windows installers).

C:\Work\Temp>C:\Python27\python.exe hg\hg clone
\\myserver\Development\MyRepo#Stage Stage
adding changesets
adding manifests
adding file changes
added 700 changesets with 26510 changes to 15012 files
updating to branch default
7259 files updated, 0 files merged, 0 files removed, 0 files unresolved

C:\Work\Temp\Stage>C:\Python27\python.exe ..\hg\hg tags
tip                              699:ef6552bd2805
Stage                            692:4f926754dc67

C:\Work\Temp\Stage>C:\Python27\python.exe ..\hg\hg summary
parent: 699:ef6552bd2805 tip
 Removed dummy comment.
branch: default
commit: (clean)
update: (current)

On 11 September 2011 01:00, HG Bot <bugs@mercurial.selenic.com> wrote:

>
> HG Bot <hgbot@quuxuum.com> added the comment:
>
> Fixed by http://selenic.com/repo/hg/rev/64fbd0de9773
> Matt Mackall <mpm@selenic.com>
> url: parse fragments first (issue2997)
>
> (please test the fix)
>
> ----------
> nosy: +hgbot
> status: chatting -> testing
>
> ____________________________________________________
> Mercurial issue tracker <bugs@mercurial.selenic.com>
> <http://mercurial.selenic.com/bts/issue2997>
> ____________________________________________________
>
msg17346 (view) Author: hgbot Date: 2011-09-11.00:00:05
Fixed by http://selenic.com/repo/hg/rev/64fbd0de9773
Matt Mackall <mpm@selenic.com>
url: parse fragments first (issue2997)

(please test the fix)
msg17344 (view) Author: kiilerix Date: 2011-09-10.09:47:37
It probably broke in 1.9 and wasn't fixed by the fix for issue2808.
msg17343 (view) Author: DanTup Date: 2011-09-10.09:35:23
I was just trying to set my build server up (CC.NET) to build fro a specific 
tag. Since it doesn't have support for this, I just added the tag to the end 
of the repo path:

\\myserver\Development\MyRepo#Stage

However, I got this error:

abort: repository \\myserver\Development\MyRepo#Stage not found!

It worked fine on my local machine (1.7). I tried upgrading my local machine 
to the latest version, and now it fails with the same error. I've included 
the commands + output below. I can't find anything online about this problem 
- is this a bug, or is this no longer supported for network file paths?

-- Commands/Output --

C:\Temp>hg version
Mercurial Distributed SCM (version 1.7.3)

C:\Temp>hg pull \\myserver\Development\MyRepo#Stage
pulling from \\myserver\Development\MyRepo
adding changesets
adding manifests
adding file changes
added 693 changesets with 26418 changes to 15011 files
(run 'hg update' to get a working copy)

C:\Temp>hg version
Mercurial Distributed SCM (version 1.9.2)

C:\Temp>hg pull \\myserver\Development\MyRepo#Stage
abort: repository \\myserver\Development\MyRepo#Stage not found!
History
Date User Action Args
2011-10-04 22:05:23mpmsetstatus: testing -> resolved
nosy: mpm, kiilerix, hgbot, DanTup, danny
2011-09-12 18:39:01DanTupsetnosy: mpm, kiilerix, hgbot, DanTup, danny
messages: + msg17376
2011-09-12 17:59:28mpmsetnosy: + mpm
messages: + msg17375
2011-09-12 07:35:23dannysetfiles: + unnamed
nosy: + danny
messages: + msg17361
2011-09-11 00:00:05hgbotsetstatus: chatting -> testing
nosy: + hgbot
messages: + msg17346
2011-09-10 09:47:38kiilerixsetstatus: unread -> chatting
nosy: kiilerix, DanTup
messages: + msg17344
2011-09-10 09:35:59kiilerixsetnosy: + kiilerix
2011-09-10 09:35:24DanTupcreate