Issue32

Title traceback on invalid .hgignore patterns
Priority bug Status resolved
Superseder Nosy List ThomasAH, mpm, tksoh, tonfa
Assigned To mpm Topics

Created on 2005-10-25.00:21:24 by mpm, last changed 2006-01-17.15:23:16 by ThomasAH.

Files
File name Uploaded Type Edit Remove
export.diff tonfa, 2005-10-25.15:19:47 text/x-patch
export.diff tonfa, 2005-10-26.14:45:28 text/plain
Messages
msg384 (view) Author: ThomasAH Date: 2006-01-17.15:23:16
works fine
msg343 (view) Author: vadim Date: 2006-01-02.23:48:36
i have made change that now prints name of hgignore file if it should.
matt, please pull it from crew.
also, message is now not so confusing with syntax entry.
msg74 (view) Author: tksoh Date: 2005-10-27.00:27:12
The tracebacks are gone, though I feel that the abort message should mention
.hgignore, for clarity. Another thing I noticed on the abort message is that the
pattern line always has a "<syntax>:" prefix added to it - even if it wasn't
there in my .hgignore file.

Else, it seemed to work fine.
msg70 (view) Author: mpm Date: 2005-10-26.23:15:16
Applied. TK, can you retest?
msg68 (view) Author: tonfa Date: 2005-10-26.14:45:28
Please apply this little fix (matchfn return None if no patterns are specified).
msg45 (view) Author: tonfa Date: 2005-10-25.15:19:47
The attached patch should fix it.
msg43 (view) Author: mpm Date: 2005-10-25.00:21:24
$ hg init
$ echo "*.o" > .hgignore
$ hg status
** unknown exception encountered, details follow
** report bug details to mercurial@selenic.com
Traceback (most recent call last):
  File "/home/oxymoron/w/h/hg/hg", line 13, in ?
    commands.run()
  File "/home/oxymoron/w/h/hg/mercurial/commands.py", line 2412, in run
    sys.exit(dispatch(sys.argv[1:]))
  File "/home/oxymoron/w/h/hg/mercurial/commands.py", line 2567, in dispatch
    return d()
  File "/home/oxymoron/w/h/hg/mercurial/commands.py", line 2552, in <lambda>
    d = lambda: func(u, repo, *args, **cmdoptions)
  File "/home/oxymoron/w/h/hg/mercurial/commands.py", line 1964, in status
    (c, a, d, u) = [[util.pathto(cwd, x) for x in n]
  File "/home/oxymoron/w/h/hg/mercurial/localrepo.py", line 467, in changes
    l, c, a, d, u = self.dirstate.changes(files, match)
  File "/home/oxymoron/w/h/hg/mercurial/dirstate.py", line 406, in changes
    for src, fn in self.walkhelper(files, statmatch, dc):
  File "/home/oxymoron/w/h/hg/mercurial/dirstate.py", line 333, in walkhelper
    sorted = [ x for x in findfiles(f) ]
  File "/home/oxymoron/w/h/hg/mercurial/dirstate.py", line 312, in findfiles
    elif statmatch(np, st) and supported_type(np, st):
  File "/home/oxymoron/w/h/hg/mercurial/dirstate.py", line 395, in statmatch
    elif not self.ignore(fn) and match(fn):
  File "/home/oxymoron/w/h/hg/mercurial/dirstate.py", line 91, in ignore
    inc=ignore)
  File "/home/oxymoron/w/h/hg/mercurial/util.py", line 182, in matcher
    return _matcher(canonroot, cwd, names, inc, exc, head, 'glob')
  File "/home/oxymoron/w/h/hg/mercurial/util.py", line 282, in _matcher
    incmatch = matchfn(map(patkind, inc), '(?:/|$)')
  File "/home/oxymoron/w/h/hg/mercurial/util.py", line 251, in matchfn
    return re.compile(pat).match
  File "/usr/lib/python2.3/sre.py", line 179, in compile
    return _compile(pattern, flags)
  File "/usr/lib/python2.3/sre.py", line 230, in _compile
    raise error, v # invalid expression
sre_constants.error: multiple repeat
History
Date User Action Args
2006-01-17 15:23:16ThomasAHsetstatus: testing -> resolved
nosy: + ThomasAH
messages: + msg384
2006-01-02 23:48:38vadimsetnosy: mpm, tonfa, tksoh
messages: + msg343
assignedto: tksoh -> mpm
2005-10-27 00:27:12tksohsetnosy: mpm, tonfa, tksoh
messages: + msg74
2005-10-26 23:15:16mpmsetassignedto: tksoh
messages: + msg70
nosy: + tksoh
2005-10-26 14:45:28tonfasetfiles: + export.diff
nosy: mpm, tonfa
messages: + msg68
2005-10-25 22:36:51mpmsetstatus: chatting -> testing
nosy: mpm, tonfa
2005-10-25 15:19:54tonfasetnosy: + tonfa
2005-10-25 15:19:47tonfasetfiles: + export.diff
status: unread -> chatting
messages: + msg45
2005-10-25 00:21:24mpmcreate